- Download Diff

Summary:

QOS Session feature implementation

Review Request #117 — Created Jan. 19, 2024 and submitted Jan. 22, 2024, 1:59 p.m.

Information
Owner:	pradeep
Repository:	APV10
Branch:	rel_apv_10_4_0_112_gail
Bugs:	279
Depends On:
Reviewers
Groups:
People:	kdutta, prajesh, roland, tanya, wli

Description

QOS Session feature implementation. Provide dedicated bandwidth for each of the session as per the user configurations.

Testing Done

qos interface "port4" IN 1Gb
qos queue root “q_default_port4_in" "port4" IN 10Mb 1 UNBORROW DEFAULT
qos dynamic abc port4 10.10.10.5 0 0.0.0.0 0 5Mb IN
qos enable port4 IN

above configuration enable to create a 5Mb bandwidth for each inbound sessions.

Issues

Description	From	Last Updated
Should we have a control to only enable dynamic qos ? qos enable port4 IN Should it be be qos …	prajesh	Jan. 20, 2024, 2:42 a.m.
any option to not to use this feature?	kdutta	Jan. 20, 2024, 2:42 a.m.
is there a impact on static QoS ?	prajesh	Jan. 20, 2024, 2:44 a.m.
if (QOSD..)	prajesh	Jan. 20, 2024, 2:44 a.m.
stick to snake case?	prajesh	Jan. 20, 2024, 2:45 a.m.
define DYNAMIC_QUEUE_PREFIX qd_	prajesh	Jan. 20, 2024, 2:45 a.m.
define filter prefix	prajesh	Jan. 20, 2024, 2:45 a.m.

Testing Done:

	+	qos interface "port4" IN 1Gb
	+	qos queue root “q_default_port4_in" "port4" IN 10Mb 1 UNBORROW DEFAULT
	+	qos dynamic abc port4 10.10.10.5 0 0.0.0.0 0 5Mb IN
	+	qos enable port4 IN
	+
	+	above configuration enable to create a 5Mb bandwidth for each inbound sessions.

branches/rel_apv_10_4_0_112_gail/usr/click/lib/libkernelapi/addCommands.pm (Diff revision 1)

Show all issues

Should we have a control to only enable dynamic qos ?

qos enable port4 IN

Should it be be qos dynamic enable port4 IN?

pradeep Jan. 20, 2024, 2:45 a.m.

once we enable qos for interface, both static and dynamic qos can be enabled. we cant restrict for only dynamic qos.

However we can have one CLI to enable/disable dynamic QOS. This check(flag) is useful. I will add in a separate ticket. it will be small change.

Diff:

Revision 2 (+714 -10)

Show changes

	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libkernelapi/addCommands.pm
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libqos_cli/qos_cli.c
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libuinet-atcp/lib/libuinet/Makefile
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.h
	5 more

branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm (Diff revision 2)
Show all issues
```
any option to not to use this feature?
```
1. pradeep Jan. 20, 2024, 2:45 a.m.
  we can have one CLI to enable/disable dynamic QOS. I will add in a separate ticket.

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.h (Diff revision 2)
Show all issues
```
is there a impact on static QoS ?
```
1. pradeep Jan. 20, 2024, 2:45 a.m.
  No
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c (Diff revision 2)
Show all issues
```
if (QOSD..)
```
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c (Diff revision 2)
Show all issues
```
stick to snake case?
```

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_subr.c (Diff revision 2)
Show all issues
```
define DYNAMIC_QUEUE_PREFIX qd_
```

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_subr.c (Diff revision 2)
Show all issues
```
define filter prefix
```

Diff:

Revision 3 (+798 -10)

Show changes

	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libkernelapi/addCommands.pm
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libqos_cli/qos_cli.c
	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libuinet-atcp/lib/libuinet/Makefile
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.h
	5 more

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Bugs:

-	278
+	279

You have a pending review.

Review Board 5.0.5

QOS Session feature implementation

Testing Done:

Diff:

define DYNAMIC_QUEUE_PREFIX qd_

define filter prefix

Diff:

Bugs:

Status: Closed (submitted)