BUG-481 SLB Virtual service with same name getting overwrite without any warning message.

Review Request #121 — Created Jan. 23, 2024 and submitted Jan. 24, 2024, 2:24 p.m.

Information
Owner:	kdutta
Repository:	APV10
Branch:	rel_apv_10_4_0_112_india, rel_apv_10_7
Bugs:	481
Depends On:
Reviewers
Groups:
People:	pradeep, prajesh, tanya

Description

Testing Done

UT Testing

AN(config)#slb virtual https "VS2" 192.168.1.191 443 arp 0
Warning! This operation will re-write the virtual service name
Type "YES" to confirm your operation:NO
Info: The action has been cancelled.

AN(config)#slb virtual https "VS2" 192.168.1.191 443 arp 0
Warning! This operation will re-write the virtual service name
Type "YES" to confirm your operation:YES

AN(config)#

Issues

Description	From	Last Updated
if find by name returns the match how is the new name different?	tanya	Jan. 24, 2024, 1:38 a.m.
Info: The action has been cancelled.	prajesh	Jan. 23, 2024, 4:43 p.m.
Could you return error code instead of 0, you can find one we already using for this type of cases. …	tanya	Jan. 24, 2024, 1:38 a.m.

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/app/slb/slb_wrapper.c (Diff revision 1)
Show all issues
```
Info: The action has been cancelled.
```

Testing Done:

		UT Testing

~		AN(config)#slb virtual http "VS_01" 192.168.1.191 80 arp 0
	~	AN(config)#slb virtual https "VS2" 192.168.1.191 443 arp 0
		Warning! This operation will re-write the virtual service name
~		Type "YES" to confirm your operation:YES
	~	Type "YES" to confirm your operation:NO
	+	Info: The action has been cancelled.

~		AN(config)#slb virtual http "VS_01" 192.168.1.191 80 arp 0
	~	AN(config)#slb virtual https "VS2" 192.168.1.191 443 arp 0
		Warning! This operation will re-write the virtual service name
~		Type "YES" to confirm your operation:NO
	~	Type "YES" to confirm your operation:YES
-		Info: operation is aborted by user.

		AN(config)#

Diff:

Revision 2 (+11)

Show changes

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/app/slb/slb_wrapper.c

Ship it!

```
Ship It!
```

Ship it!

```
ship it
```

Ship it!

Branch:

-	rel_apv_10_4_0_112_india
+	rel_apv_10_4_0_112_india, rel_apv_10_7

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/app/slb/slb_wrapper.c (Diff revision 1)
Show all issues
```
if find by name returns the match how is the new name different?
```

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/app/slb/slb_wrapper.c (Diff revision 2)

Show all issues

Could you return error code instead of 0, you can find one we already using for this type of cases. The cli return codes are logges and show in "show log b b" so they have a meaning.

kdutta Jan. 24, 2024, 1:38 a.m.

This is how existing one is using, so i am using the same.

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

BUG-481 SLB Virtual service with same name getting overwrite without any warning message.

UT Testing

Testing Done:

UT Testing

Diff:

Branch:

Status: Closed (submitted)