Bug 609 - HSOL-3794 / debug ftp / Download file name from FTP is not same as show debug file

Review Request #156 — Created Feb. 27, 2024 and submitted

mmiriam
APV10
rel_apv_10.7
609
pradeep, prajesh, tanya

Download file name from FTP is not same as show debug file from WebUI and CLI

I have tested with the release build Rel_apv_10.7 release. debug ftp commands works fine as per my testing.

AN#show debug file
File Size Time
sslkeylog 712 Feb 26 11:46:47 2024
sys_debug_20240226_114647 1023 Feb 26 11:46:47 2024

1.[WebUI / Test002]
01: WebUI > System > Admin Tools > Troubleshooting > Debug File
02: Select and check "sys_debug_20240226_114647.tar.gz"
03: ACTIONS > Export

[root@localhost array]# ls
sys_debug_20240226_114647.tar.gz

  1. [CLI / Test003]
    AN(config)#debug ftp array 192.168.172.130 sys_debug

[root@localhost array]# ls
sys_debug_20240226_114647.tar.gz

  1. [CLI / Test 004]
    AN(config)#debug ftp array 192.168.172.130 sys_debug_20240226_114647

[root@localhost array]# ls
sys_debug_20240226_114647.tar.gz
4.
AN(config)#debug ftp array 192.168.172.130 all
[root@localhost array]# ls

sslkeylog_20240227_081351.tar.gz.gpg sys_debug_20240226_114647.tar.gz

Description From Last Updated

can u test with sys_debug file

pradeeppradeep

use strlen()

pradeeppradeep
prajesh
  1. Ship It!
  2. 
      
prajesh
  1. Please check if branch is open for commits before committing anything to the release branch.

  2. 
      
pmurugaiyan
  1. 
      
  2. Just an observation:

    In the outer if condition(#98) we have strncmp(filename,"sys_debug", strlen("sys_debug")) == 0 and similarly, in the inner if condition, we are using strncmp(filename,"sys_debug", strlen("sys_debug")) > 0. In which scenario, the inner if condition will become true!

  3. 
      
mmiriam
tanya
  1. Ship It!
  2. 
      
mmiriam
  1. 
      
  2. when debug ftp provides sys_debug file with timestamp and else case for debug ftp command without sys_debug timestamp
  3. 
      
pradeep
  1. 
      
    1. 103 - if(strncmp(filename,"sys_debug", strlen(filename)) > 0) {
      103 + if(strlen(filename) > strlen("sys_debug"))

  2. 
      
pradeep
  1. 
      
  2. can u test with sys_debug file

  3. 
      
mmiriam
pradeep
  1. Ship It!
  2. 
      
mmiriam
Review request changed

Status: Closed (submitted)

Loading...