- Download Diff

Summary:

Bug 494 - SQA: misleading error message from config mem.

Review Request #176 — Created March 12, 2024 and discarded March 26, 2024, 3:48 p.m.

Information
Owner:	rodiveedu
Repository:	APV10
Branch:	rel_apv_10_7
Bugs:	494
Depends On:
Reviewers
Groups:
People:	pradeep, prajesh, tanya

Description

Testing Done

login as: array
array@192.168.162.148's password:
Pre-authentication banner message from server:
|
| The user "array" will be locked if it fails to log in more than 4 consecutive

times. End of banner message from server Access denied array@192.168.162.148's password: Last login: Wed Mar 6 06:34:21 2024 from 192.168.172.5 ArrayOS Rel.APV.10.7.0.6 - untagged unofficial build by uid=0(root) gid=0(root) groups=0(root) on DevRohith: on Mon Feb 19 02:26:27 2024 Copyright (c) 2000-2024 Array Networks Inc. All rights reserved.

Type "?" for available commands

!!Reminder!! Please log on to the WebUI to register this system.

AN>en

Enable password:

AN#

sh ver

ArrayOS Rel.APV.10.7.0.6 - untagged unofficial build by uid=0(root) gid=0(root) groups=0(root) on DevRohith: on Mon Feb 19 02:26:27 2024

Host name : AN

System CPU : Intel(R) Xeon(R) CPU
System RAM : 3879500 kbytes.

System boot time : Mon Mar 04 11:32:55 GMT (+0000) 2024
Current time : Thu Mar 07 03:06:27 GMT (+0000) 2024
System up time : 2 days, 15 hrs, 34 mins
Platform Bld Date : Mon Mar 04 11:31:28 GMT 2024
SSL HW : No HW Available
Compression HW : No HW Available
Network Interface : 4 x 10Gigabit Ethernet fiber
Model : Array vAPV
Serial Number : 0E1A9B919165C00005012640101756
Licensed Limits : vCPUs(x32), NICs(x16), RAM(16 GB), Bandwidth(123 Gbps)
Licensed Features : WebWall Clustering L4SLB L7SLB Caching
SSL tProxy SwCompression LLB CCB GSLB
QoS MultiLang DynRoute IPv6
License Key : 78ed2085-72c03e0f-0d943ab6-349e678d-81997f93-4f78f480-0455f8ab-20240227-99999999

Array Networks Customer Support
Telephone : 1-877-992-7729 (1-877-99-ARRAY)
Email : support@arraynetworks.com
Update : please contact support for instructions
Website : http://www.arraynetworks.com

Other Root Version
Rel.APV.10.3.0.2 build on Fri Dec 28 21:53:13 2018

AN#
AN#
AN#conf t

AN(config)#clear config all
There isn't ssl host
Cache not on.
SameSite cookie attribute is removed from all virtual services!
The admin role separation mode has been disabled.
A default user "array" will be added after the execution of this operation.
Please delete the default user "array" after creating a new user.
synconfig secure has already been on!
The device does not have an SSL card or is forced to use soft SSL. This command is not supported.
WAF feature not licensed
Please contact Array Networks representative to enable this feature.
No SSL card available
Interface port1 already up
Interface port2 already up
Interface port3 already up
Interface port4 already up

AN(config)#sh ip add

AN(config)#show ip address
ip address "port1" 192.168.162.148 255.255.255.0

AN(config)#ip add

AN(config)#ip address port2 192.168.162.145 255.255.255.0
Subnet overlap between port2 and port1
Failed to execute "ip address port2 192.168.162.145 255.255.255.0"

AN(config)#config meme
config meme
^

AN(config)#conf

AN(config)#config mem

AN(config)#config memory
Error: this subnet is already used by port1 interface
Please turn on sdns first.
Please turn on sdns first.
Please turn on sdns first.
Please turn on sdns first.
Please turn on sdns first.
No SSL card available
No SSL card available
User name "array" has existed.
The admin role separation mode has been disabled.
Success stop website classify process
Online website classification lookup is already disabled.
global regexcase mode changed
This http rewrite body mimetype is already configured
This response code is already configured
DNS virtual service
NAT64 isn't enabled.
DNS virtual service name
system interface name or "all"
Please turn on lldp
Please turn on lldp
Please turn on lldp

AN(config)#

Issues

Description	From	Last Updated
Can you please explain the reason behind the change? What insert is pointing to NULL.	prajesh	March 14, 2024, 7:49 p.m.
Should not check cur == next. I dont see the point of doing pointer comarision. You should the check the …	prajesh	March 14, 2024, 7:57 p.m.
are we check the value here?	kdutta	March 19, 2024, 3:52 p.m.

branches/rel_apv_10_7/usr/src/sys/click/app/segment/segment_cli_kern.c (Diff revision 1)

Show all issues

Can you please explain the reason behind the change? What insert is pointing to NULL.

rodiveedu March 18, 2024, 7:58 p.m.

The change was made to avoid unnecessary comparisons between the insert pointer and the current pointer within the loop. By checking if the insert pointer is equal to the current pointer, we skip the comparison when the insert pointer points to the same location as the current pointer, which represents self-comparison.

The pointer comparison was used to check if the insert pointer is equal to the current pointer, indicating self-comparison.we skip the comparison when the insert pointer points to the same location as the current pointer.

Fix it!

branches/rel_apv_10_7/usr/src/sys/click/app/segment/segment_cli_kern.c (Diff revision 1)

Show all issues

Should not check cur == next. I dont see the point of doing pointer comarision. You should the check the contents if insert is not NULL and you want to compare whether current and prev pointers contain the same value.

People:

+	pradeep

Fix it!

branches/rel_apv_10_7/usr/src/sys/click/app/segment/segment_cli_kern.c (Diff revision 1)

Show all issues

are we check the value here?

rodiveedu March 20, 2024, 11:33 a.m.

No Ansuk, in the change, we are not directly checking the values of the IP addresses. Instead, we are checking whether the pointer insert points to the same node as curr. we skip the comparison to avoid detecting overlap with itself.

You have a pending review.

Review Board 5.0.5

Bug 494 - SQA: misleading error message from config mem.

People:

Status: Discarded