-
-
-
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c (Diff revision 1) better to have a #define for 50000 since its used in several places
-
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c (Diff revision 1) so this does not have lock before setting her but the idea is that its protected by the cli kapi_lock, is that correct?
-
do we need to unlock here as well since we are returning?
maybe better make a goto and unlock in one spot? but i know sometimes reorganising the finc to have a goto will add more issues, so it's up to you if you want to change tp goto.
QoS memory corruption issue
Review Request #199 — Created March 22, 2024 and updated
| Information | |
|---|---|
| pradeep | |
| APV10 | |
| 10_4_0_122_gail | |
| 640 | |
| Reviewers | |
| kdutta, prajesh, roland, tanya | |
Memory corruption in QoS due to race conditions between the atcp threads.
Now thread Mutex are used to lock and unlock critical sections
| Description | From | Last Updated |
|---|---|---|
|
intead of using a global lock, use a lock at the queue level , it will be efficient and granular. |
 prajesh
|
|
|
We dont create a filter when it is cleaning up.. So we should have a bug to improvise this or … |
prajesh
|
|
|
please remove the spaces/tabs |
 tanya
|
|
|
what is 2 here? Can we have a #define ? |
prajesh
|
|
|
why it is called as temp_q_count? can we call it "set_session_queue_count" something more meaningful ? |
prajesh
|
|
|
better to have a #define for 50000 since its used in several places |
tanya
|
|
|
so this does not have lock before setting her but the idea is that its protected by the cli kapi_lock, … |
tanya
|
|
|
do we need to unlock here as well since we are returning? maybe better make a goto and unlock in … |
tanya
|
|
|
remove temp |
prajesh
|
|
|
temp is redundant... you print directly from pQoSQRoot->sQNam |
prajesh
|
-
-
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_classq.h (Diff revision 1) intead of using a global lock, use a lock at the queue level , it will be efficient and granular.
-
We dont create a filter when it is cleaning up.. So we should have a bug to improvise this or record this as a known limitation.
-
-
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c (Diff revision 1) why it is called as temp_q_count? can we call it "set_session_queue_count" something more meaningful ?
-
-
