QoS Session : Changes related to optimising the code

Review Request #206 — Created March 27, 2024 and updated

Information
pradeep
APV10
10_4_0_112_gail
649
Reviewers
kdutta, prajesh, roland, tanya 
Optimizing QoS session code for better performance.

Also provided engineering CLI to configure maximum session count CLI.




 














 

 






 
 
 

  

   

    
   

   
    
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
   

  

  

   
    

     Description
     From
     Last Updated
    

   
   



    

     
      
      
Probably safer to add CMD_KAPI_LOCK flag, when set it ensures value is not modified at the same time as atcps …

     		
     
      tanyatanya
     
     
      
     
    




    

     
      
      
how do make sure n_filters dont go ove the limit QOS_MAX_FLTR_NUM?

     		
     
      tanyatanya
     
     
      
     
    


   
  

 












  

 








 














 



 

  

   




pradeep




   

   

  

 



 















 



 

  

   




pradeep




   

   

  

 



 















 



 

  

   




pradeep




   

   

  

 



 















 





 

  

   




tanya




   

   







  

 



 

  


   

   

    
 
tanya


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Probably safer to add CMD_KAPI_LOCK flag, when set it ensures value is not modified at the same time as atcps access it.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




tanya




   

   







  

 



 

  


   

   

    
 
tanya


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    how do make sure n_filters dont go ove the limit QOS_MAX_FLTR_NUM?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      current_dyn_q_count will make sure we delete queues and filters once we reach max_dyn_queue (whose value will always be kept less then QOS_MAX_FLTR_NUM
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




prajesh




   

   







  

 



 

  


   

   

    
 
prajesh


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pradeep




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Diff:

   
    
 Revision 4 (+81 -15)
Show changes
 
    branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm 
    branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c 
    branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.h 
    branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c 
    branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_scheduler.c 
 

   		
  



 










  

 
















 





 

  

   




tanya




   

   







  

 



 

  


   

   

    
 
tanya


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...