Qos Session : slowness in customer environment with QoS Session featur

Review Request #239 — Created May 7, 2024 and updated May 7, 2024, 6:27 p.m.

Description

Slowness observed at more then 10K PPS.

Testing Done

Tested successfully with 30K PPS. Slowness is not observed from the end users internet access via APV which process all proxy's requests

Issues

Description	From	Last Updated
mutex destroy?	prajesh	May 7, 2024, 3:43 p.m.
remove extra space.	prajesh	May 7, 2024, 3:41 p.m.
remove whitespaces.	prajesh	May 7, 2024, 3:41 p.m.
remove white space	prajesh	May 7, 2024, 3:41 p.m.
is this change intentional?	prajesh	May 7, 2024, 3:44 p.m.
This is the max mbuf's that can be in the class. Original value is 1024. I have changed to 2048 …	pradeep	May 7, 2024, 3:43 p.m.
what is this for?	prajesh	May 7, 2024, 3:44 p.m.
unused?	prajesh	May 7, 2024, 5:48 p.m.

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_scheduler.h (Diff revision 1)

Show all issues

This is the max mbuf's that can be in the class.
Original value is 1024.
I have changed to 2048 as sometime pending mbuf's are > 1024.

Revision 2 (+308 -69)

	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_subr.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c
	4 more

Ship it!

Revision 3 (+307 -69)

	branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_subr.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_classifier.c
	4 more

Ship it!

You have a pending review.