- Download Diff

Summary:

Bug 678 : APV 9800 device self-rebooted |AS-12512| NPCI-UPI

Review Request #267 — Created May 28, 2024 and updated July 12, 2024, 1:22 p.m.

Information
Owner:	rvempati
Repository:	APV10
Branch:	rel_apv_10_4_0_112_india
Bugs:
Depends On:
Reviewers
Groups:
People:	kdutta, pradeep, prajesh, tanya

Description

Ported the fixes from the relevant bug 645.

Testing Done

Updated the code with only commands.pm file changes.

And the code is compiled successfully.
chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1|grep version"

tcpdump version 4.5.1

libpcap version 1.7.3

./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k                                                                                     

tools/click_priv_key.pem

signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array

[root@devrohit rel_apv_10_4_0_112_india]#

Issues

Description	From	Last Updated
Hi Rohit, the 645 fix in is only in 2 files your change looks different. Was the code base different?	tanya	May 30, 2024, 11:17 a.m.
Where else the code makes use of EROUTE_RTS_UPDATE?	prajesh	May 29, 2024, 2:45 p.m.
Intent here is to create a RTS entry for non SYACK TCP packet. Is this correct?	prajesh	May 29, 2024, 4:41 p.m.
if you want to update every other packet, then you dont need a check .you can ust use the else …	prajesh	May 30, 2024, 11:16 a.m.
Is there a code which makees use of EROUTE_RTS_BSD?	prajesh	June 7, 2024, 2:29 p.m.
can you explain what lock does?	prajesh	July 10, 2024, 4:35 p.m.

Ship it!

```
Ship It!
```

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.c (Diff revision 1)

Show all issues

Where else the code makes use of EROUTE_RTS_UPDATE?

rvempati May 29, 2024, 2:49 p.m.

usr/src/sys/click/netinet/click_input.c
usr/src/sys/click/net/click_ether.c

there are two other files that use EROUTE_RTS_UPDATE, and are included with this comment.

```
Ignore my shipit.
```

Change Summary:

Modified two more files that use EROUTE_RTS_UPDATE

Testing Done:

		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
		tcpdump version 4.5.1
		libpcap version 1.7.3
		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
		[root@devrohit rel_apv_10_4_0_112_india]#

		Compiled the modified code successfully, also generated the ".array" image
	+
	+	After new modifications for the ENABLE_RTS_UPDATE usage in other files,
	+	usr/src/sys/click/netinet/click_input.c
	+	usr/src/sys/click/net/click_ether.c
	+
	+	the code is successfully compiled.
	+
	+	chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
	+	tcpdump version 4.5.1
	+	libpcap version 1.7.3
	+	./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
	+	signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
	+	[root@devrohit rel_apv_10_4_0_112_india]#

Diff:

Revision 2 (+24 -11)

Show changes

	branches/rel_apv_10_4_0_112_india/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/net/click_ether.c
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.h
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.c
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_input.c

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/net/click_ether.c (Diff revision 2)

Show all issues

Intent here is to create a RTS entry for non SYACK TCP packet. Is this correct?

rvempati May 29, 2024, 3:45 p.m.

only syn create rts, others do update only

rvempati May 29, 2024, 4:41 p.m.

"rts_create" to create or update a routing entry with the flags EROUTE_RTS_BSD | EROUTE_RTS_UPDATE.

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/net/click_ether.c (Diff revision 2)

Show all issues

if you want to update every other packet, then you dont need a check .you can ust use the else part?

rvempati May 30, 2024, 11:18 a.m.

Reverting the code changes.
As mentioned, the else part would suffice and already in the code before changing.

Show all issues

Hi Rohit,
the 645 fix in is only in 2 files your change looks different. Was the code base different?

rvempati May 30, 2024, 11:18 a.m.

No, i used the rel_apv_10_7_0 to check the diff.
And updated in the rel_apv_10_4_0_112_india repo.

Change Summary:

Reverted the files click_ether.c and click_input.c

Testing Done:

		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
		tcpdump version 4.5.1
		libpcap version 1.7.3
		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
		[root@devrohit rel_apv_10_4_0_112_india]#

		Compiled the modified code successfully, also generated the ".array" image

	+
	+
		After new modifications for the ENABLE_RTS_UPDATE usage in other files,
		usr/src/sys/click/netinet/click_input.c
~		usr/src/sys/click/net/click_ether.c
~
	~	usr/src/sys/click/net/click_ether.c
	~	the code is successfully compiled.
-		the code is successfully compiled.

		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
		tcpdump version 4.5.1
		libpcap version 1.7.3
		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
		[root@devrohit rel_apv_10_4_0_112_india]#
	+
	+
	+
	+	After reverting the files click_ether.c and click_input.c, the code compilation is successful.
	+	chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
	+	tcpdump version 4.5.1
	+	libpcap version 1.7.3
	+	./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
	+	signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
	+	[root@devrohit rel_apv_10_4_0_112_india]#

Diff:

Revision 3 (+16 -7)

Show changes

	branches/rel_apv_10_4_0_112_india/usr/click/lib/libparser/commands.pm
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.h
	branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.c

branches/rel_apv_10_4_0_112_india/usr/src/sys/click/netinet/click_eroute.c (Diff revision 3)

Show all issues

Is there a code which makees use of EROUTE_RTS_BSD?

rvempati June 7, 2024, 2:29 p.m.

Yes,
At troubleshooting times from the eroute rules configurations, the EROUTE_RTS_BSD flag is used.
find_egroup() at 13284 in this file itself.

Change Summary:

Updated the code with only commands.pm file changes.

Testing Done:

~		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
	~	Updated the code with only commands.pm file changes.
-		tcpdump version 4.5.1
-		libpcap version 1.7.3
-		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
-		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
-		[root@devrohit rel_apv_10_4_0_112_india]#
-
-		Compiled the modified code successfully, also generated the ".array" image
-
-
-
-		After new modifications for the ENABLE_RTS_UPDATE usage in other files,
-		usr/src/sys/click/netinet/click_input.c
-		usr/src/sys/click/net/click_ether.c
-		the code is successfully compiled.

		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
		tcpdump version 4.5.1
		libpcap version 1.7.3
~		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
~		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
	~	./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k
	~	tools/click_priv_key.pem
-		[root@devrohit rel_apv_10_4_0_112_india]#
-
-
-
-		After reverting the files click_ether.c and click_input.c, the code compilation is successful.
-		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
-		tcpdump version 4.5.1
-		libpcap version 1.7.3
-		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k tools/click_priv_key.pem
		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
		[root@devrohit rel_apv_10_4_0_112_india]#

Diff:

Revision 4 (+3 -3)

Show changes

branches/rel_apv_10_4_0_112_india/usr/click/lib/libparser/commands.pm

Change Summary:

Updated the review request for commands.pm file

Testing Done:

~		Updated the code with only commands.pm file changes.
	~	Updated the code with only commands.pm file changes.
	+	And the code is compiled successfully.

		chroot pack/install_root su - root -c "/ca/bin/tcpdump -h 2>&1\|grep version"
		tcpdump version 4.5.1
		libpcap version 1.7.3
		./tools/sign_pack -o ArrayOS-Rel_APV_10_4_0_112_6.array -i ustackupdate.tar.gz -k
		tools/click_priv_key.pem
		signed package created :ArrayOS-Rel_APV_10_4_0_112_6.array
		[root@devrohit rel_apv_10_4_0_112_india]#

branches/rel_apv_10_4_0_112_india/usr/click/lib/libparser/commands.pm (Diff revision 4)

Show all issues

can you explain what lock does?

rvempati July 10, 2024, 4:35 p.m.

/these must match the definitions in kernelapi/generator/kernelWrapGen.pm/ and one of them is this KAPI_LOCK.
That CMD_KAPI_LOCK is defined with 0x1000 and is used to prevent the race conditions implying the synchronization/consistency

pradeep July 10, 2024, 4:53 p.m.

is this a port from a different fix.?
How to verify this change will fix the issue ?

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

Bug 678 : APV 9800 device self-rebooted |AS-12512| NPCI-UPI

Change Summary:

Testing Done:

Diff:

Change Summary:

Testing Done:

Diff:

Change Summary:

Testing Done:

Diff:

Change Summary:

Testing Done: