Bug 783 - Add "interface shutdown" series commands

Review Request #305 — Created July 1, 2024 and submitted

Information
luhsuan
AVX2
rel_avx_2_7_2
783
Reviewers
jasonchou, kdutta, tanya, timlai, weikai 
Add these interface shutdown series commands:


    

  • interface shutdown <port number> : shutdown an interface (with dropping its connection) by the port number.
    • 

  • no interface shutdown <port number> : bring up an interface (with bringing up its connection) by the port number.
    • 



In order to support the link-down-on-close feature on i40e driver with version 1.4.25 (we have difficuity to merely upgrade the driver to at least version 2.0.26 as APV 10.4 encounters some problems on it), we create a patch to i40e driver so that the driver does support such feature.
    

  • (PASSED) The interface should have the following actions after executing interface shutdown:
      

    • The LED does not shine.
      • 

    • The connection is down (showing messages like i40e <PCI-E position> <interface name>: NIC Link is Down in dmesg).
      • 

    

    • 

  • (PASSED) The interface should have the following actions after executing no interface shutdown:
      

    • The LED does shine.
      • 

    • The connection is up (showing message like i40e <PCI-E position> <interface name>: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None in dmesg).
      • 

    

    •
Description From Last Updated

Modify the kickstart file to download i40e-1.4.25.12.rpm

 timlaitimlai

Update version to 12

 timlaitimlai

Formatting issues

 timlaitimlai

Add error message for mgmt port

 timlaitimlai

can you please fix the allignement. We normally follow the same allignment while check in new codes.

 kduttakdutta

are we updating the driver here?

 kduttakdutta
luhsuan
luhsuan
timlai
timlai 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Update version to 12
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Formatting issues
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Hi Tim,
      
So what kind of the if statement formatting will you suggest?
      
As the if statement contains a long condition.
      
 
      

      2. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




luhsuan




   

   

  

 



 















 





 

  

   




timlai




   

   







  

 



 

  


   

   

    
 
timlai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Modify the kickstart file to download i40e-1.4.25.12.rpm
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Thanks for the reminder.
      
By the way, are there any tutorials or procedures to upload i40e-1.4.25.12.rpm to file server?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Give RPM to weikai, he will help you to upload to repo server
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Hi Tim,
      

      I confirm the  i40e-1.4.25-12 is served on http://192.168.100.11/avxepel.72/.
      
 
      

      4. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




luhsuan




   

   

  

 



 















 



 

  

   




luhsuan




   

   

  

 



 















 





 

  

   




timlai




   

   







  

 



 

  


   

   

    
 
timlai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Add error message for mgmt port
    
  
    
 
    

 
    
  



 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




luhsuan




   

   

  

 



 















 



 

  

   




luhsuan




   

   

  

 



 















 





 

  

   




timlai




   

   







  

 



 

  


   

   

    
 
timlai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




kdutta




   

   







  

 



 

  


   

   

    
 
kdutta


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    can you please fix the allignement. We normally follow the same allignment while check in new codes.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Before applying the alignment,
      
I would like to ask what is your suggestion of Perl indentation as the commands.pm applies tabs as well as spaces.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      What's more, the commands.pm suggest to use tab for indentation.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Done.
      
 
      

      4. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    are we updating the driver here?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yes.
      
I am going to update the driver hosted on file server as I am going to add new patch to the driver.
      
 
      

      2. 


 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 





 

  

   




weikai




   

   







  

 



 

  


   

   

    
 
weikai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




luhsuan




   

   

  

 



 















 



 

  

   




luhsuan




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...