Network slowness with QoS Session

Review Request #312 — Created July 3, 2024 and updated July 4, 2024, 4:54 p.m.

Information
Owner:	pradeep
Repository:	APV10
Branch:	10_4_0_112_gail
Bugs:	902
Depends On:
Reviewers
Groups:
People:	kdutta, prajesh, roland, tanya

Description

At customer environment we see users experiencing slowness at random times at random PPS. Changes made to improve the mbuf processing. Also too many debug logs were adding to the slowness.

Testing Done

Tested with high PPS 70K pps IN/OUT (which more then double the PPS seen at customer place[peak time].)

below are the configs used.

log level "info"
log off

qos interface "port5" OUT 3Gb
qos enable "port5" OUT
qos interface "port5" IN 3Gb
qos enable "port5" IN
qos queue root "q_default_port5_out" "port5" OUT 3Gb 1 UNBORROW DEFAULT
qos queue root "q_default_port5_in" "port5" IN 3Gb 1 UNBORROW DEFAULT
qos sessionon
qos sespacketcnt 50
qos sessionqdelstepcount 1
qos qlenwait 1027
qos qosclasscnt 48
qos qosclspos 8

Issues

Description	From	Last Updated
do you need this log?	prajesh	July 3, 2024, 9:59 p.m.
remove space	kdutta	July 3, 2024, 10 p.m.
t = 2 is already there before the log.	prajesh	July 3, 2024, 10 p.m.
same	kdutta	July 3, 2024, 10 p.m.
This sounds a kludge to me. We should debug why and when is this happening.	prajesh	July 4, 2024, 3:14 p.m.

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c (Diff revision 1)
Show all issues
```
do you need this log?
```
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c (Diff revision 1)
Show all issues
```
t = 2 is already there before the log.
```
1. pradeep July 3, 2024, 10 p.m.
  thats the 'else' part. There is a different calculation for 'if' clause.

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c (Diff revision 1)
Show all issues
```
remove space
```
branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c (Diff revision 1)
Show all issues
```
same
```

Diff:

Revision 2 (+52 -16)

Show changes

	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_cbq.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_dynamic.c
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_scheduler.h
	branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/qos_subr.c

branches/rel_apv_10_4_0_112_gail/usr/src/sys/click/app/qos/altq_rmclass.c (Diff revision 2)

Show all issues

This sounds a kludge to me. We should debug why and when is this happening.

pradeep July 4, 2024, 3:14 p.m.

effectively this clause will always be false.
We have reset the qlen to original 1024 packets.(from 2048 packets). So enqueue will fail if the queue is full
And by default q_len_wait we are setting more then 1024. so this clause will always be false, unless we alter the q_len_wait from eng cli.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

Network slowness with QoS Session

Diff: