Bug 1131 - Request for SNMP OID for LLB link status report

Review Request #499 — Created Oct. 18, 2024 and submitted

mmiriam
APV10
rel_apv_10.7
1131
kdutta, prajesh, tanya

Bug 1131 -Enhancement request for SNMP OID for other missing LLB link status report

Output before code changes:
[root@AN test]# snmpwalk -v 2c -c public 192.168.162.137 1.3.6.1.4.1.7564.34
SNMPv2-SMI::enterprises.7564.34.2.1.1.0 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.1.1 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.2.1 = STRING: "Array_BLR"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.3.1 = STRING: "192.168.162.1"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.4.1 = STRING: "Up"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.5.1 = STRING: "0.000ms"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.6.1 = STRING: "00:16:54"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.7.1 = STRING: "00:00:00"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.8.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.9.1 = STRING: "Link is Up"

Output after code changes:
[root@AN test]# snmpwalk -v 2c -c public 192.168.162.137 1.3.6.1.4.1.7564.34
SNMPv2-SMI::enterprises.7564.34.2.1.1.0 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.1.1 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.2.1 = STRING: "Array_BLR"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.3.1 = STRING: "192.168.162.1"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.4.1 = STRING: "Up"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.5.1 = STRING: "0.000ms"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.6.1 = STRING: "00:04:56"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.7.1 = STRING: "00:00:00"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.8.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.9.1 = STRING: "Link is Up"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.10.1 = STRING: "0bps"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.11.1 = STRING: "0bps"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.12.1 = STRING: "10485760kbps"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.13.1 = INTEGER: 4
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.14.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.15.1 = INTEGER: 0

Description From Last Updated

please remove spaces at the end of the lines through out the diff

tanyatanya

why do we have to multiply by 1024. If there is an overflow, what is the idea for multiplying?

prajeshprajesh

remove all extra whitespaces

prajeshprajesh

sapce after if. if () { }

prajeshprajesh

should it be bandwidth_out?

prajeshprajesh

why do we need this check?

prajeshprajesh
tanya
  1. 
      
  2. please remove spaces at the end of the lines through out the diff

  3. 
      
prajesh
  1. 
      
  2. why do we have to multiply by 1024.

    If there is an overflow, what is the idea for multiplying?

    1. Here I'm trying to keep all the values in same units for calculating usage value even though we are getting kbps converted bandwidth from llb_hc.c, when bandwidth value is greater than INT_MAX

  3. remove all extra whitespaces

  4. sapce after if.

    if () {
    }

  5. 
      
mmiriam
prajesh
  1. Ship It!
  2. 
      
prajesh
  1. 
      
  2. should it be bandwidth_out?

  3. why do we need this check?

    1. As discussed added comments to explain the same

  4. 
      
prajesh
  1. Ship It!
  2. 
      
mmiriam
tanya
  1. Ship It!
  2. 
      
mmiriam
Review request changed

Status: Closed (submitted)

Loading...