- Download Diff

Summary:

API to get LLB values for listing page

Review Request #633 — Created Jan. 28, 2025 and submitted Feb. 4, 2025, 5:19 p.m.

Information
Owner:	apoorva.sn
Repository:	AMP
Branch:	amp_3_7
Bugs:	AA-2572
Depends On:
Reviewers
Groups:
People:	pmurugaiyan, prajesh, shuinvy

Description

Problem

API to get LLB values for listing page:
Link Name, Gateway IP, Status, Bandwidth Threshold, Bandwidth Usage, Bandwidth In, Bandwidth Out, Connections, Hits

API to get LLB values for Dashboard page:
hits, connections

Solution

Have introduced a new logic to get the LLB Stats and the monitoring data values from Influx DB

Testing Done

Tested with the Postman using following URL:
1. Listing Page
https://192.168.85.47:8888/llb/stats

{"action":"get_llb_stats"}

{
"results": [
{
"statement_id": 0,
"series": [
{
"name": "llbStats",
"tags": {
"agent_host": "192.168.85.101"
},
"columns": [
"time",
"linkName",
"linkGateway",
"linkStatus",
"linkThresh",
"linkUsage",
"linkBandwidIn",
"linkBandwidOut",
"linkConn",
"linkHits"
],
"values": [
[
1738049430000,
"VLAN-162",
"192.168.162.1",
"Up",
"10485760kbps",
0,
"0bps",
"0bps",
0,
1482
],
[
1738049430000,
"VLAN-85",
"192.168.85.1",
"Up",
"10485760kbps",
0,
"0bps",
"0bps",
1,
1483
]
]
}
]
}
]
}

Monitoring Page
https://192.168.85.47:8888/llb/monitoring_data

{
"results": [
{
"statement_id": 0,
"series": [
{
"name": "llbStats",
"columns": [
"time",
"top",
"linkName",
"agent_host"
],
"values": [
[
1738147200812,
0,
"VLAN-162",
"192.168.85.101"
],
[
1738147200812,
0,
"VLAN-85",
"192.168.85.101"
]
]
}
]
},
{
"statement_id": 1,
"series": [
{
"name": "llbStats",
"columns": [
"time",
"top",
"linkName",
"agent_host"
],
"values": [
[
1738147210000,
4,
"VLAN-85",
"192.168.85.101"
],
[
1738147210000,
1,
"VLAN-162",
"192.168.85.101"
]
]
}
]
}
]
}

Issues

Description	From	Last Updated
can we introduce a repo layer to interact with db. Extending current design makes the code a lot harder to …	prajesh	Jan. 31, 2025, 6:48 p.m.
can be llb/stats	prajesh	Jan. 31, 2025, 9:18 p.m.
300 seconds sounds too much. 15 seconds should be ideal keeping user experience in mind. You dont want to frustrate …	prajesh	Jan. 31, 2025, 9:18 p.m.
what is the idea here? We pass the SQL query in the POST method and then we get the DB …	prajesh	Jan. 31, 2025, 9:20 p.m.
Should we combine these two into one API call. Any reason to keep them separate?	prajesh	Jan. 31, 2025, 9:22 p.m.
do we need POST here? Is there away to change it to GET.	prajesh	Feb. 3, 2025, 5:40 p.m.
Same here.. as per handler it is doing a GET action.	prajesh	Feb. 3, 2025, 5:40 p.m.

Change Summary:

Updated review for adding logic to get the monitoring data for hits and connections

Description:

		Problem

		API to get LLB values for listing page:
		Link Name, Gateway IP, Status, Bandwidth Threshold, Bandwidth Usage, Bandwidth In, Bandwidth Out, Connections, Hits

	+	API to get LLB values for Dashboard page:
	+	hits, connections
	+
		Solution

~		Have introduced a new method "get_llb_stats" to get the LLB Stats values from Influx DB
	~	Have introduced a new methods "get_llb_stats", get_llb_stats_monitoring_data to get the LLB Stats values from Influx DB

Testing Done:

		Tested with the Postman using following URL:
	+	1. Listing Page
		https://192.168.85.47:8888/composer_query

	+	{"action":"get_llb_stats"}
	+
		{
		"results": [
		{
		"statement_id": 0,
		"series": [
		{
		"name": "llbStats",
		"tags": {
		"agent_host": "192.168.85.101"
		},
		"columns": [
		"time",
		"linkName",
		"linkGateway",
		"linkStatus",
		"linkThresh",
		"linkUsage",
		"linkBandwidIn",
		"linkBandwidOut",
		"linkConn",
		"linkHits"
		],
		"values": [
		[
		1738049430000,
		"VLAN-162",
		"192.168.162.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		0,
		1482
		],
		[
		1738049430000,
		"VLAN-85",
		"192.168.85.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		1,
		1483
		]
		]
		}
		]
		}
		]
		}
	+
	+
	+
	+	Dashboard Page
	+
	+	{"action":"get_llb_stats_monitoring_data"}
	+
	+
	+
	+	{
	+	"results": [
	+	{
	+	"statement_id": 0,
	+	"series": [
	+	{
	+	"name": "llbStats",
	+	"columns": [
	+	"time",
	+	"top",
	+	"linkName",
	+	"agent_host"
	+	],
	+	"values": [
	+	[
	+	1738147200812,
	+	0,
	+	"VLAN-162",
	+	"192.168.85.101"
	+	],
	+	[
	+	1738147200812,
	+	0,
	+	"VLAN-85",
	+	"192.168.85.101"
	+	]
	+	]
	+	}
	+	]
	+	},
	+	{
	+	"statement_id": 1,
	+	"series": [
	+	{
	+	"name": "llbStats",
	+	"columns": [
	+	"time",
	+	"top",
	+	"linkName",
	+	"agent_host"
	+	],
	+	"values": [
	+	[
	+	1738147210000,
	+	4,
	+	"VLAN-85",
	+	"192.168.85.101"
	+	],
	+	[
	+	1738147210000,
	+	1,
	+	"VLAN-162",
	+	"192.168.85.101"
	+	]
	+	]
	+	}
	+	]
	+	}
	+	]
	+	}

Diff:

Revision 2 (+35)

Show changes

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/services/composer_query_service.py

Diff:

Revision 3 (+35)

Show changes

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/services/composer_query_service.py

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/services/composer_query_service.py (Diff revision 3)

Show all issues

can we introduce a repo layer to interact with db. Extending current design makes the code a lot harder to refactor at a later point in time.

apoorva.sn Jan. 31, 2025, 9:22 p.m.

Introduced DB layer to handle DB requests for LLB Stats

Diff:

Revision 4 (+36)

Show changes

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/services/composer_query_service.py

Description:

		Problem

		API to get LLB values for listing page:
		Link Name, Gateway IP, Status, Bandwidth Threshold, Bandwidth Usage, Bandwidth In, Bandwidth Out, Connections, Hits

		API to get LLB values for Dashboard page:
		hits, connections

		Solution

~		Have introduced a new methods "get_llb_stats", get_llb_stats_monitoring_data to get the LLB Stats values from Influx DB
	~	Have introduced a new logic to get the LLB Stats and the monitoring data values from Influx DB

Testing Done:

		Tested with the Postman using following URL:
		1. Listing Page
~		https://192.168.85.47:8888/composer_query
	~	https://192.168.85.47:8888/llbstats

		{"action":"get_llb_stats"}

		{
		"results": [
		{
		"statement_id": 0,
		"series": [
		{
		"name": "llbStats",
		"tags": {
		"agent_host": "192.168.85.101"
		},
		"columns": [
		"time",
		"linkName",
		"linkGateway",
		"linkStatus",
		"linkThresh",
		"linkUsage",
		"linkBandwidIn",
		"linkBandwidOut",
		"linkConn",
		"linkHits"
		],
		"values": [
		[
		1738049430000,
		"VLAN-162",
		"192.168.162.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		0,
		1482
		],
		[
		1738049430000,
		"VLAN-85",
		"192.168.85.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		1,
		1483
		]
		]
		}
		]
		}
		]
		}



~		Dashboard Page
	~	Monitoring Page https://192.168.85.47:8888/llbstats/monitoring_data

~		{"action":"get_llb_stats_monitoring_data"}
	~



		{
		"results": [
		{
		"statement_id": 0,
		"series": [
		{
		"name": "llbStats",
		"columns": [
		"time",
		"top",
		"linkName",
		"agent_host"
		],
		"values": [
		[
		1738147200812,
		0,
		"VLAN-162",
		"192.168.85.101"
		],
		[
		1738147200812,
		0,
		"VLAN-85",
		"192.168.85.101"
		]
		]
		}
		]
		},
		{
		"statement_id": 1,
		"series": [
		{
		"name": "llbStats",
		"columns": [
		"time",
		"top",
		"linkName",
		"agent_host"
		],
		"values": [
		[
		1738147210000,
		4,
		"VLAN-85",
		"192.168.85.101"
		],
		[
		1738147210000,
		1,
		"VLAN-162",
		"192.168.85.101"
		]
		]
		}
		]
		}
		]
		}

Diff:

Revision 5 (+157)

Show changes

	branches/amp_3_7/src/webui/webui/htdocs/new/src/djproject/urls.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/__init__.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/llb_stats_queries.py

branches/amp_3_7/src/webui/webui/htdocs/new/src/djproject/urls.py (Diff revision 5)
Show all issues
```
can be llb/stats
```

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/llb_stats_queries.py (Diff revision 5)

Show all issues

300 seconds sounds too much. 15 seconds should be ideal keeping user experience in mind. You dont want to frustrate the use working on the UI :)

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/llb_stats_queries.py (Diff revision 5)

Show all issues

what is the idea here? We pass the SQL query in the POST method and then we get the DB response in the POST call?

apoorva.sn Jan. 31, 2025, 9:22 p.m.

here we are constructing a query whether agent_host info is provided. If it is there in the POST request then we use the 2nd query

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 5)

Show all issues

Should we combine these two into one API call. Any reason to keep them separate?

apoorva.sn Jan. 31, 2025, 9:22 p.m.

Better to keep them seperate as get_llb_stats_query_str get the query string and execute_db_query executes the query. We might have different query string for every method but execute_db_query can be same.

prajesh Feb. 3, 2025, 5:21 p.m.

execute_db_query is something db layer logic. Upper level layers shoudl not care about how how db gets it. This breaks the encapsulation principle.

prajesh Feb. 3, 2025, 5:25 p.m.

llb_stats.py is it part of the repo layer or not? if this is the part of repo layer, then current code is okay.

Change Summary:

Incorporated the comments

Diff:

Revision 6 (+164)

Show changes

	branches/amp_3_7/src/webui/webui/htdocs/new/src/djproject/urls.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/__init__.py
	branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/db/llb_stats_queries.py

Testing Done:

		Tested with the Postman using following URL:
		1. Listing Page
~		https://192.168.85.47:8888/llbstats
	~	https://192.168.85.47:8888/llb/stats

		{"action":"get_llb_stats"}

		{
		"results": [
		{
		"statement_id": 0,
		"series": [
		{
		"name": "llbStats",
		"tags": {
		"agent_host": "192.168.85.101"
		},
		"columns": [
		"time",
		"linkName",
		"linkGateway",
		"linkStatus",
		"linkThresh",
		"linkUsage",
		"linkBandwidIn",
		"linkBandwidOut",
		"linkConn",
		"linkHits"
		],
		"values": [
		[
		1738049430000,
		"VLAN-162",
		"192.168.162.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		0,
		1482
		],
		[
		1738049430000,
		"VLAN-85",
		"192.168.85.1",
		"Up",
		"10485760kbps",
		0,
		"0bps",
		"0bps",
		1,
		1483
		]
		]
		}
		]
		}
		]
		}



~		Monitoring Page https://192.168.85.47:8888/llbstats/monitoring_data
	~	Monitoring Page https://192.168.85.47:8888/llb/monitoring_data





		{
		"results": [
		{
		"statement_id": 0,
		"series": [
		{
		"name": "llbStats",
		"columns": [
		"time",
		"top",
		"linkName",
		"agent_host"
		],
		"values": [
		[
		1738147200812,
		0,
		"VLAN-162",
		"192.168.85.101"
		],
		[
		1738147200812,
		0,
		"VLAN-85",
		"192.168.85.101"
		]
		]
		}
		]
		},
		{
		"statement_id": 1,
		"series": [
		{
		"name": "llbStats",
		"columns": [
		"time",
		"top",
		"linkName",
		"agent_host"
		],
		"values": [
		[
		1738147210000,
		4,
		"VLAN-85",
		"192.168.85.101"
		],
		[
		1738147210000,
		1,
		"VLAN-162",
		"192.168.85.101"
		]
		]
		}
		]
		}
		]
		}

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 6)

Show all issues

do we need POST here? Is there away to change it to GET.

apoorva.sn Feb. 3, 2025, 5:40 p.m.

As of now we dont have the functionality to get the username from the session and to get the hosts which are accessible to the user.
so using POST only as of now to get the hosts information

branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 6)

Show all issues

Same here.. as per handler it is doing a GET action.

apoorva.sn Feb. 3, 2025, 5:40 p.m.

As of now we dont have the functionality to get the username from the session and to get the hosts which are accessible to the user.
so using POST only as of now to get the hosts information

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

API to get LLB values for listing page

Problem

Solution

Change Summary:

Description:

Problem

Solution

Testing Done:

Diff:

Diff:

Diff:

Description:

Problem

Solution

Testing Done:

Diff:

Change Summary:

Diff:

Testing Done:

Status: Closed (submitted)