Bug 1131 - Need SNMP OID for LLB link status report in integer format

Review Request #636 — Created Feb. 3, 2025 and submitted

mmiriam
APV10
rel_apv_10.7
1131
phemadri, pradeep, prajesh, tanya

Bug 1131 - Need SNMP OID for LLB link status report in integer format. Currently bandwidth IN/Out is showing in string format so, converted to integer format in kbps units.

[root@AN test]# snmpwalk -v 2c -c public 192.168.162.137 1.3.6.1.4.1.7564.34

SNMPv2-SMI::enterprises.7564.34.2.1.1.0 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.1.1 = INTEGER: 1
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.2.1 = STRING: "Array_BLR"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.3.1 = STRING: "192.168.162.1"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.4.1 = STRING: "Up"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.5.1 = STRING: "0.000ms"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.6.1 = STRING: "00:11:28"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.7.1 = STRING: "00:00:00"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.8.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.9.1 = STRING: "Link is Up"
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.10.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.11.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.12.1 = INTEGER: 10485760
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.13.1 = INTEGER: 4
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.14.1 = INTEGER: 0
SNMPv2-SMI::enterprises.7564.34.2.1.2.1.15.1 = INTEGER: 0

Description From Last Updated

is this going to be Kilo Bytes per second or kilobits per second. Bandwidth is generally bits per second. kbps …

prajeshprajesh

Should this be 1000? check the calculations for b/w

prajeshprajesh

same here.

prajeshprajesh

B stands for bytes. b is used for bits. Bytes or bits?

prajeshprajesh

same here.

prajeshprajesh

why do we need this check? if return value is long_ret?

prajeshprajesh

Should it be 1000 instead of 1024? BW calculations use 1000 for kilo if I am not wrong.

prajeshprajesh
phemadri
  1. 
      
  2. as uint64 is being returned, if possible change this to 'long' as similar other functions are doing

    1. Yes, I missed to update return value. Will update it to long

  3. as uint64 is being returned, if possible change this to 'long' as similar other functions are doing

  4. as uint64 is being returned, if possible change this to 'long' as similar other functions are doing

  5. 
      
prajesh
  1. 
      
  2. is this going to be Kilo Bytes per second or kilobits per second. Bandwidth is generally bits per second.

    kbps = (bytes per second * 8)/1000. Uniti 1000 if I am not wrong.

    1. Yes, bandwidth will be in bits per second but in code they are converting it to bytes and then to KB. return bandwidth8UL/10; in function llb_get_link_avg_bandwidth_in/out. So I have removed the convertion in to KBps in the new _kern function

  3. Should this be 1000? check the calculations for b/w

    1. as in function llb_get_link_avg_bandwidth_in/out bandwidth in bits/sec is already converting it to Kilo bytes per sec so we can remove bandwidth/1024 in this function

  4. 
      
mmiriam
prajesh
  1. 
      
  2. B stands for bytes. b is used for bits. Bytes or bits?

  3. why do we need this check? if return value is long_ret?

  4. 
      
prajesh
  1. 
      
  2. Should it be 1000 instead of 1024? BW calculations use 1000 for kilo if I am not wrong.

  3. 
      
mmiriam
prajesh
  1. Ship It!
  2. 
      
mmiriam
phemadri
  1. Ship It!
  2. 
      
mmiriam
Review request changed

Status: Closed (submitted)

Loading...