AA-2312: Backend changes to get the LLB data for the PDF generation
Review Request #677 — Created Feb. 24, 2025 and updated
| Information | |
|---|---|
| apoorva.sn | |
| AMP | |
| amp_3_7 | |
| AA-2312 | |
| Reviewers | |
| pmurugaiyan, prajesh, shuinvy | |
Problem
Backend changes to get the LLB data for the PDF generation
Refactored my previous changes for LLBSolution
Introduced new End point /report/pdf for generation report as PDF
https://192.168.85.47:8888/report/pdf
{
"result": true,
"filename": "LLB_Statistics_Report_from_2025_02_25_19_40_04_to_2025_02_25_19_25_04.pdf"
}Attached PDF created
| Description | From | Last Updated |
|---|---|---|
|
Please change epoch timestamp to local timezone or timezone set in AMP. It will be more readable. |
|
|
|
can we make endpoint something like reports?format=pdf |
|
|
|
LLB_Statistics_Report_ |
|
|
|
Can we use relative path? |
|
|
|
Constants/Global variables in Caps? |
|
|
|
Can we keep the alignments similar to other reports? Also please add from and to time in readable format in … |
|
|
|
Please update with logger. |
|
|
|
Do we need a import here? |
|
|
|
Please attach updated PDF report. |
|
|
|
can we store in the same location as other generated pdff files. |
|
|
|
Since, we have only one API endpoint to request download the PDF file. How we are supporting downloading the generated … |
|
-
-
branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 1) Please change epoch timestamp to local timezone or timezone set in AMP. It will be more readable.
-
-
branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 1) can we make endpoint something like reports?format=pdf
-
branches/amp_3_7/src/webui/webui/htdocs/new/src/hive/llb_stats.py (Diff revision 1) LLB_Statistics_Report_
-
-
-
-
Testing Done: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+453 -101) |
-
-
branches/amp_3_7/amp.spec (Diff revision 2) can we store in the same location as other generated pdff files.
-
-
branches/amp_3_7/src/webui/webui/htdocs/new/src/djproject/urls.py (Diff revision 2) Since, we have only one API endpoint to request download the PDF file. How we are supporting downloading the generated pdf file for later usage? Also, what if the data is huge, as we dont have the queue in place, what if the request got timeout!
