APV - Port QoS feature to 10_7 special branch for GAIL customer

Review Request #683 — Created Feb. 26, 2025 and updated

pradeep
APV10
10_7_2_14_qos
AE-1058
mmiriam, phemadri, prajesh, rvempati, tanya

Port QoS feature from GAIL branch 10_4_0_112_gail branch to 10_7 special branch (10_7_2_14_qos) for GAIL customer

AN#show qos session ?
config Show configurations of QoS Session
count Show Session Count

AN(config)#qos ?
disable Deactivate QoS interface
enable Activate QoS interface
filter Configure QoS L4 filter
interface Configure QoS interface
queue Configure QoS queue
session Configure QoS Session

AN(config)#qos

AN(config)#qos session ?
add Add QoS Session Configuration
off Deactivate QoS Session
on Activate QoS Session

Description From Last Updated

can this be qos session on|off

prajeshprajesh

qos session off ?

prajeshprajesh

Do we need extra 1K classes?

prajeshprajesh

please remove this line, there are couple more white spaces in the rest of the diff, please remove those as …

tanyatanya

can total_outstanding already point to something here?

tanyatanya

please remove white space

tanyatanya

clean this up code if not needed.

prajeshprajesh
pradeep
prajesh
pradeep
pradeep
pradeep
tanya
  1. 
      
  2. please remove this line, there are couple more white spaces in the rest of the diff, please remove those as well

  3. can total_outstanding already point to something here?

    1. cbqp->cbq_qlen will be updated as and when we process the mbuf from the queue. This variable holds that info. This help us to know if we have long(too many) pending mbuf in the queue.

  4. 
      
pradeep
pradeep
pradeep
Review request changed
tanya
  1. Ship It!
  2. 
      
prajesh
  1. 
      
  2. Do we need extra 1K classes?

    1. 1024 I have accounted for static classes (which was original number).

  3. clean this up code if not needed.

    1. we can keep it. Usefull for debugging

  4. 
      
prajesh
  1. Ship It!
  2. 
      
phemadri
  1. Ship It!
  2. 
      
rvempati
  1. Ship It!
  2. 
      
Loading...