-
-
branches/main/array-ingress-controller/apvadapter/client.go (Diff revision 1) boileplate is not accurate.
-
-
branches/main/array-ingress-controller/apvadapter/client.go (Diff revision 1) please fix the indentation everywhere..
-
branches/main/array-ingress-controller/configstore/db.go (Diff revision 1) can we define a environment variable for this or if not a constant?
-
-
branches/main/array-ingress-controller/main.go (Diff revision 1) Remove the whitespaces as a best practice.
-
branches/main/array-ingress-controller/main.go (Diff revision 1) same here .. everywhere in the review. We follow this in APV code base?
-
branches/main/array-ingress-controller/main.go (Diff revision 1) Remove commented out code if not needed.
Code commit for Ingress Controller Sprint 2
Review Request #685 — Created Feb. 27, 2025 and updated
| Information | |
|---|---|
| Arjun | |
| Ingress_controller | |
| Reviewers | |
| Aman, prajesh | |
This is the review request for the code for Ingress controller sprint 2.
Investigate the functionalities of the commited modules
| Description | From | Last Updated |
|---|---|---|
|
boileplate is not accurate. |
 prajesh
|
|
|
indentation.. |
prajesh
|
|
|
please fix the indentation everywhere.. |
prajesh
|
|
|
can we define a environment variable for this or if not a constant? |
prajesh
|
|
|
remove extra space |
prajesh
|
|
|
do we need knobs to control whether to enable APV vs ASF? |
prajesh
|
|
|
Can we not use a golnag packge for logging? |
prajesh
|
|
|
Remove the whitespaces as a best practice. |
prajesh
|
|
|
same here .. everywhere in the review. We follow this in APV code base? |
prajesh
|
|
|
Remove commented out code if not needed. |
prajesh
|
-
-
branches/main/array-ingress-controller/controller/openshift-controller/event-handlers/pod_event_handler.go (Diff revision 1) do we need knobs to control whether to enable APV vs ASF?
-
branches/main/array-ingress-controller/logger/logger.go (Diff revision 1) Can we not use a golnag packge for logging?