Support Layer 4 and below IP fragementation support in APV
Review Request #724 — Created March 17, 2025 and updated
| Information | |
|---|---|
| satyendra | |
| APV10 | |
| 10.7 | |
| AE-583 | |
| Reviewers | |
| phemadri, pradeep, prajesh, tanya, wli | |
To support IP fragmented packet in the APV . The IP fragmenat packet will be created based on output interface.
Added command as below to disable/enable IP frag feature .
ip reassembly off .
ip reassembly on
show ip reassembly
The testing is done with traffic of 3KB payload running , which is received as IP fragment as done by router .
| Description | From | Last Updated |
|---|---|---|
|
remove whitespaces. |
 prajesh
|
|
|
can multiple threads use the same array? make it local to the function? |
prajesh
|
|
|
do we need -1? |
prajesh
|
|
|
clean this up. |
prajesh
|
|
|
dont we have to set MF flag in IP header for initial few packets? |
prajesh
|
|
|
IP vs IPv6? Should we handle IPv4 explicitly? |
prajesh
|
|
|
can we not set ip_frag_reass (static variable) directly instead of using sysctl. If we are using sysctl, then CLI may … |
prajesh
|
|
|
You need to print the exact CLI. |
prajesh
|
|
|
Need to print exact CLI. |
prajesh
|
|
|
can you add commands.pm? |
prajesh
|
|
|
Print exact CLI |
prajesh
|
|
|
Not related with CSUM (csum) |
prajesh
|
|
|
though it says unused , it is still used in the code.. pls use a different flag. |
prajesh
|
|
|
Do we need nic_init()? |
prajesh
|
|
|
Enable IP fragmentation and reassembly |
prajesh
|
|
|
Disable IP fragmentation and reassembly. |
prajesh
|
|
|
similar to adding write_func to write table you need to add clear func to clear table. It's in the same … |
 tanya
|
|
|
caller frees this one? |
prajesh
|
|
|
what happens to the mbuf that we processed until line 1060? |
prajesh
|
Change Summary:
add coomad to enable/disable IP frag feature
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+242 -10) |
-
-
branches/rel_apv_10_7/usr/src/sys/sys/mbuf.h (Diff revision 4) though it says unused , it is still used in the code.. pls use a different flag.
-
-
branches/rel_apv_10_7/usr/click/lib/libip/sip.c (Diff revision 4) can we not set ip_frag_reass (static variable) directly instead of using sysctl. If we are using sysctl, then CLI may not be needed.
Change Summary:
Added TCp checksum , write mem command and other issue Fix
Change Summary:
removed Junked file and fixed proper indent
Diff: |
Revision 6 (+344 -14)
|
|---|
-
-
-
branches/rel_apv_10_7/usr/click/lib/libparser/commands.pm (Diff revision 6) Enable IP fragmentation and reassembly
-
branches/rel_apv_10_7/usr/click/lib/libparser/commands.pm (Diff revision 6) Disable IP fragmentation and reassembly.
Change Summary:
changes as per the review comment
Diff: |
Revision 7 (+339 -14)
|
|---|
-
-
branches/rel_apv_10_7/usr/click/bin/backend/sys_tool.c (Diff revision 7) similar to adding write_func to write table you need to add clear func to clear table. It's in the same file. look for clear_ip_dhcp() as an example. The clear function needs to restore the setting to default, so if our default is on it simply needs to call the on function. The clear table is used when we run "clear config" command, so if we miss adding this the ip frag setting will not be restored when we run clear config.
thanks
Change Summary:
The Ip fragment support feature is added in clear config frameowrk.
Diff: |
Revision 8 (+351 -14)
|
|---|
Change Summary:
optimise the packet processing . Now the ip fragmented packet are sent as batch of 32 packets.
Diff: |
Revision 9 (+36 -17) |
|---|
-
-
branches/rel_apv_10_7_2_17_sidra/usr/click/lib/libuinet-atcp/lib/libuinet/uinet_if_dpdk.c (Diff revision 9) what happens to the mbuf that we processed until line 1060?
