Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+547 -2) |
AA-2588 Expose LLB NAT Statistics from APV for AMP Dashboard
Review Request #731 — Created March 20, 2025 and submitted
| Information | |
|---|---|
| ngurunathan | |
| APV10 | |
| rel_apv_10.7 | |
| AA-2588 | |
| Reviewers | |
| mmiriam, pradeep, prajesh, tanya | |
AA-2588 Expose LLB NAT Statistics from APV for AMP Dashboard.Eexpose LLB NAT-related statistics so that AMP can receive and visualize key NAT traffic details, including NAT IP, Destination IP, Source Port, Destination Port.
snmpwalk -v 2c -m /ca/etc/mibs/CA-SNMP-MIB.txt -c public 192.168.162.73 1.3.6.1.4.1.7564.34.2.2
CA-SNMP-MIB8::natStatsCount.0 = INTEGER: 3
CA-SNMP-MIB8::natIndex.1 = INTEGER: 1
CA-SNMP-MIB8::natIndex.2 = INTEGER: 2
CA-SNMP-MIB8::natIndex.3 = INTEGER: 3
CA-SNMP-MIB8::natSourceIP.1 = STRING: 30.30.30.10
CA-SNMP-MIB8::natSourceIP.2 = STRING: 30.30.30.10
CA-SNMP-MIB8::natSourceIP.3 = STRING: 30.30.30.10
CA-SNMP-MIB8::natLocalIP.1 = STRING: 192.168.162.73
CA-SNMP-MIB8::natLocalIP.2 = STRING: 192.168.163.73
CA-SNMP-MIB8::natLocalIP.3 = STRING: 192.168.163.73
CA-SNMP-MIB8::natTargetIP.1 = STRING: 20.7.2.167
CA-SNMP-MIB8::natTargetIP.2 = STRING: 192.168.160.11
CA-SNMP-MIB8::natTargetIP.3 = STRING: 52.123.129.14
CA-SNMP-MIB8::natSourcePort.1 = INTEGER: 57335
CA-SNMP-MIB8::natSourcePort.2 = INTEGER: 65286
CA-SNMP-MIB8::natSourcePort.3 = INTEGER: 65285
CA-SNMP-MIB8::natLocalPort.1 = INTEGER: 58119
CA-SNMP-MIB8::natLocalPort.2 = INTEGER: 58210
CA-SNMP-MIB8::natLocalPort.3 = INTEGER: 58207
CA-SNMP-MIB8::natTargetPort.1 = INTEGER: 443
CA-SNMP-MIB8::natTargetPort.2 = INTEGER: 7680
CA-SNMP-MIB8::natTargetPort.3 = INTEGER: 443
| Description | From | Last Updated |
|---|---|---|
|
remove white spaces from everywhere (shown in red) |
 prajesh
|
|
|
Align second column for better readability. |
prajesh
|
|
|
Remove all whitespaces |
 mmiriam
|
|
|
give some readable variable names |
mmiriam
|
|
|
can this be renamed to result from "string" |
prajesh
|
|
|
if (port_ptr == NULL) { return NULL; } else { ... } Follow this if else structure.. |
prajesh
|
|
|
Change it to below format / current index is the required pcb index. Based on nat attribute type, * update … |
mmiriam
|
|
|
add space after if and between "==" |
mmiriam
|
|
|
Chnage if else formatting everywhere |
prajesh
|
|
|
if () { } else { } |
prajesh
|
-
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/CA-SNMP-MIB.txt (Diff revision 2) Remove all whitespaces
-
branches/rel_apv_10_7/usr/src/sys/click/netinet/click_pcb.c (Diff revision 2) give some readable variable names
-
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/CA-SNMP-MIB.txt (Diff revision 2) remove white spaces from everywhere (shown in red)
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/CA-SNMP-MIB.txt (Diff revision 2) Align second column for better readability.
-
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/llbMIB.c (Diff revision 3) can this be renamed to result from "string"
-
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/llbMIB.c (Diff revision 3) if (port_ptr == NULL) {
return NULL;
} else {
...
}Follow this if else structure..
-
-
branches/rel_apv_10_7/usr/src/sys/click/netinet/click_pcb.c (Diff revision 3) Change it to below format
/ current index is the required pcb index. Based on nat attribute type,
* update buffer with corresponding nat detail
/ -
branches/rel_apv_10_7/usr/src/sys/click/netinet/click_pcb.c (Diff revision 3) add space after if and between "=="
Change Summary:
Addressed review comments
Diff: |
Revision 4 (+548 -22)
|
|---|
-
-
branches/rel_apv_10_7/usr/click/lib/libca_snmp_mib/llbMIB.c (Diff revision 4) Chnage if else formatting everywhere
Change Summary:
Formatted if else
Diff: |
Revision 5 (+545 -22)
|
|---|
Change Summary:
Added spaces wherever needed
Diff: |
Revision 6 (+545 -22)
|
|---|