-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm (Diff revision 1) can this be comma separated?
-
-
-
-
-
AE-243 On LLB Setup RTS causing an issue |AS-18589| GAI
Review Request #756 — Created March 31, 2025 and submitted
| Information | |
|---|---|
| mmiriam | |
| APV10 | |
| rel_apv_10_4_0_112_gail | |
| AE-243 | |
| Reviewers | |
| pradeep, prajesh, tanya | |
AE-243 On LLB Setup RTS causing an issue |AS-18589| GAIL. Added fix to avaoid all other packets other than SYN in rts create and added a workaround cli "ip rts blacklist [ip1,1p2.. ]/[disable]" to block specifc ip's to create an entry when they enter as destination ip's in rts_create function
| Description | From | Last Updated |
|---|---|---|
|
can this be comma separated? |
 prajesh
|
|
|
is this valdi for ipv6 as well? |
prajesh
|
|
|
Is this not same as ICMP over IPv6? |
prajesh
|
|
|
Can we add a log to indicate the blacklisting |
prajesh
|
|
|
a space after else. |
prajesh
|
|
|
Do we need these logs ? Can we increase count to 500. |
prajesh
|
|
|
How can we see the blacklist config? We need a show rts blacklist cli too ? |
prajesh
|
|
|
can we use "off" instead of "disable". We use on or off in other places .. ip rts on ip … |
prajesh
|
|
|
define MAX_RTS_BLACKLIST 64 |
prajesh
|
|
|
space after if |
prajesh
|
|
|
We dont care about update entries.. can we log only the once we are going to add wrongly? |
prajesh
|
|
|
command should be show ip rts blacklist. What is it now? |
prajesh
|
|
|
for 64 IPS you need 64 * 40 atleasst. |
prajesh
|
|
|
blacklist_ip_rts already allocates memory.. so no need of allocating here.. |
prajesh
|
|
|
should be off here to be consistent. |
prajesh
|
|
|
256 may not be enough? |
prajesh
|
|
|
also free buf? |
prajesh
|
|
|
check the limits ..otherwise, user can be more than 64 and this can cause mem corruption.. be defensive. |
prajesh
|
|
|
we need this for \0 ? |
prajesh
|
|
|
seems to be a debug log. Should not get printed in CLI |
prajesh
|
|
|
free is missing. |
prajesh
|
|
|
plz #define the number 256 |
 pradeep
|
|
|
strcat seems issue here. we are doing malloc and doing strcat with single bit initialed to zero. should we intitialize … |
pradeep
|
-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm (Diff revision 2) How can we see the blacklist config? We need a show rts blacklist cli too ?
-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm (Diff revision 2) can we use "off" instead of "disable". We use on or off in other places ..
ip rts on
ip rts off.
-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libparser/commands.pm (Diff revision 3) command should be show ip rts blacklist. What is it now?
Description: |
|
|---|
-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libip/sip.c (Diff revision 4) for 64 IPS you need 64 * 40 atleasst.
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libip/sip.c (Diff revision 4) blacklist_ip_rts already allocates memory.. so no need of allocating here..
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libip/sip.c (Diff revision 4) should be off here to be consistent.
-
-
branches/rel_apv_10_4_0_112_gail/usr/click/lib/libip/sip.c (Diff revision 8) plz #define the number 256
-
strcat seems issue here. we are doing malloc and doing strcat with single bit initialed to zero. should we intitialize whole string