TWSD-636 "slb direct fwd" enables TCP failure connecting
Review Request #786 — Created April 11, 2025 and submitted
| Information | |
|---|---|
| tanya | |
| APV10 | |
| rel_apv_10_7, rel_apv_10_7_3. | |
| TWSD-636 | |
| Reviewers | |
| peteryeh, prajesh, satyendra, timlai, timsu | |
Ported the fix for Bj bug BJ Bug139213 TCP Connection Failure Issue with DirectFWD and SYN Packets. However I do not think Bj fix is %100 correct (condition in Bj fix (tuples->th->th_flags & TH_SYN)), it does not check for flags that not supposed to be set (for example syn_ack), so I put different condition that Bj fix.
Original BJ fix from rel_apv_10_4_2. is below
Index: fastslb_tcp.c
===================================================================
--- fastslb_tcp.c (revision 36634)
+++ fastslb_tcp.c (revision 36635)
@@ -426,7 +426,7 @@
/When syn_cache_enable is off,
reverse mode,transparent mode, only SYN packet can build fastpcb.
*/
- if(tuples->th->th_flags == TH_SYN) {
+ if(tuples->th->th_flags & TH_SYN) {
return fasttcp_passive_open(tuples, m, vs_p, real_ifp, NULL);
} else {
if (cross_numa_enable && numa_dispatcher && ATCP_IS_L4() && numa_enqueue(m)) {
| Description | From | Last Updated |
|---|---|---|
|
space after if? |
 prajesh
|
Description: |
|
|---|