AE-1179 Support H323 video conference feature

Review Request #812 — Created April 21, 2025 and discarded May 6, 2025, 6:05 p.m.

Information
Owner:	pradeep
Repository:	APV10
Branch:	rel_apv_10_7_2_17_bhel_h323_nat
Bugs:	AE-1179
Depends On:
Reviewers
Groups:
People:	ngurunathan, prajesh

Description

H323 involves set of protocol suits. Mainly h225 & h245. Certain packets of these protcol carry the IP address on the payload as per the protocol requirements. ASN1C library is used & modified to parse these packets and update the internal IP that they carry in payload with the NAT IP.

Testing Done

tested H225 setup. H245 OpenLogicChannel and OpenLogicChannelAck packets

Issues

Description	From	Last Updated
remove whitespace .	prajesh	April 22, 2025, 3:10 p.m.
why we added this argument?	prajesh	April 22, 2025, 3:10 p.m.
Do we need DEBUG flag?	prajesh	April 22, 2025, 3:10 p.m.
Could have done INCS += ASN_MODULE_HDRS	prajesh	April 22, 2025, 3:10 p.m.
Add this to makefile to make it easier.	prajesh	April 22, 2025, 3:10 p.m.
what about h225? we dont do the changes?	prajesh	April 23, 2025, 12:59 p.m.
remove debug logs.	prajesh	April 23, 2025, 12:59 p.m.
do we neet natport also?	prajesh	April 22, 2025, 3:32 p.m.
How does this change the value in packet?	prajesh	April 22, 2025, 3:10 p.m.
whitespaces.	prajesh	April 22, 2025, 3:10 p.m.
whats happening here? Please explain the logic.	prajesh	April 22, 2025, 3:10 p.m.
ideally the caller should free it. Why it is done here?	prajesh	April 22, 2025, 3:10 p.m.
did we add these changes?	prajesh	April 23, 2025, 12:59 p.m.
define 1720	prajesh	April 22, 2025, 4:23 p.m.
Can we have a macro to make code readbale?	prajesh	April 22, 2025, 4:23 p.m.
what is 0x3 and 0x22 ? can we have helper routines or macros define IS_H245_TRAFFIC(tacp_paylad_begin) (tcp_payload_begin[0] == 0x03) && (tcp_payload_begin[1] …	prajesh	April 22, 2025, 4:23 p.m.

Fix it!

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/ANY.c (Diff revision 1)
Show all issues
```
remove whitespace .
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/INTEGER.c (Diff revision 1)
Show all issues
```
why we added this argument?
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile (Diff revision 1)
Show all issues
```
Do we need DEBUG flag?
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile.am.libasncodec (Diff revision 1)
Show all issues
```
Could have done INCS += ASN_MODULE_HDRS
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/OCTET_STRING.c (Diff revision 1)
Show all issues
```
Add this to makefile to make it easier.
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)

Show all issues

How does this change the value in packet?

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)

Show all issues

whitespaces.

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
whats happening here?  Please explain the logic.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)
Show all issues
```
ideally the caller should free it. Why it is done here?
```

Fix it!

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
do we neet natport also?
```

Fix it!

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
define 1720
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
Can we have a macro to make code readbale?
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)

Show all issues

what is 0x3 and 0x22 ? can we have helper routines or macros
define IS_H245_TRAFFIC(tacp_paylad_begin) (tcp_payload_begin[0] == 0x03) && (tcp_payload_begin[1] == 0x00) &&
                (tcp_payload_begin[4] == 0x22))

Fix it!

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/OCTET_STRING.c (Diff revision 1)
Show all issues
```
what about h225?  we dont do the changes?
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/asn_bit_data.c (Diff revision 1)
Show all issues
```
remove debug logs.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)
Show all issues
```
did we add these changes?
```

You have a pending review.

Review Board 5.0.5

AE-1179 Support H323 video conference feature

define 1720

define IS_H245_TRAFFIC(tacp_paylad_begin) (tcp_payload_begin[0] == 0x03) && (tcp_payload_begin[1] == 0x00) &&

Status: Discarded