- Download Diff

Summary:

AE-1179 Support H323 video conference feature

Review Request #842 — Created May 6, 2025 and submitted June 10, 2025, 6:56 p.m.

Information
Owner:	pradeep
Repository:	APV10
Branch:	rel_apv_10_7_2_17_bhel_h323_nat
Bugs:	AE-1179
Depends On:
Reviewers
Groups:
People:	ngurunathan, prajesh

Description

H323 involves set of protocol suits. Mainly h225 & h245. Certain packets of these protcol carry the IP address on the payload as per the protocol requirements. ASN1C library is used & modified to parse these packets and update the internal IP that they carry in payload with the NAT IP.

Testing Done

tested H225 setup. H245 OpenLogicChannel and OpenLogicChannelAck packets. Payloads of these protocol updated with NAT IP replacing the local ip.

Cli added:

AN#sh h323
H323 natting is enabled.

AN#
AN(config)#h323 ?
nat enable/disable natting

AN(config)#h323 nat ?
disable Disable H225 natting
enable Enable H323 natting

AN(config)#h323 nat enable

AN(config)#

Issues

Description	From	Last Updated
pass it from Makefile. CFLAGS += -DDEBUG_LOG	prajesh	June 9, 2025, 1:28 p.m.
change status => action ?	prajesh	June 9, 2025, 1:28 p.m.
remove these debugs if they are no longer needed.	prajesh	June 9, 2025, 1:28 p.m.
white spaces.	prajesh	June 9, 2025, 1:28 p.m.
space after if.	prajesh	June 9, 2025, 1:28 p.m.
make offset < len check before indexing.	prajesh	June 9, 2025, 1:29 p.m.
rename it as H323_PACKET_NOT_OURS	prajesh	June 9, 2025, 1:29 p.m.
add offset < len checks to avoid buffer overflows.	prajesh	June 9, 2025, 1:29 p.m.
what are 1C and 1E. please add some comments and add necessary #defines	prajesh	June 9, 2025, 1:29 p.m.
define and add comments to understand the logic better.	prajesh	May 9, 2025, 12:49 p.m.
Pass it from Makefile.	prajesh	June 9, 2025, 1:30 p.m.
Use Makefile to define macros -DDEBUG_LOG.	prajesh	June 9, 2025, 1:30 p.m.
remove whitespace changes from all other places.	prajesh	June 9, 2025, 1:30 p.m.
if (extpresent)	prajesh	June 9, 2025, 1:31 p.m.
we dont use uper.. do we need this change ?	prajesh	June 9, 2025, 1:34 p.m.
these logs are not useful.. clean them up.	prajesh	June 9, 2025, 1:34 p.m.
make the cli h225 nat enable and h245 nat enable	prajesh	June 9, 2025, 1:44 p.m.
Enable H225 natting.	prajesh	June 9, 2025, 1:36 p.m.
Configute H245 natting.	prajesh	June 9, 2025, 1:36 p.m.
Enable H245 natting.	prajesh	June 9, 2025, 1:36 p.m.
Disable H245 natting	prajesh	June 9, 2025, 1:36 p.m.
H225_ENABLED for better readability. Same for H245.	prajesh	June 9, 2025, 1:36 p.m.
it is a config rather than a status.	prajesh	June 9, 2025, 1:36 p.m.
Make it explicit.. H225 natting.	prajesh	June 9, 2025, 1:36 p.m.
write memory changes missing.. reboot and check. Also, do we need clear CLI?	prajesh	June 9, 2025, 1:37 p.m.
can we split nat_h323_payload into two functions nat_h225_payload() and nat_h245_payload(), Otherwise, fixing one might break other one..	prajesh	June 9, 2025, 1:37 p.m.

Fix it!

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/OCTET_STRING.c (Diff revision 1)
Show all issues
```
pass it from Makefile.
CFLAGS += -DDEBUG_LOG
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/OCTET_STRING.c (Diff revision 1)
Show all issues
```
change status => action ?
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/asn_bit_data.c (Diff revision 1)

Show all issues

remove these debugs if they are no longer needed.

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)

Show all issues

white spaces.

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
space after if.
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)

Show all issues

make offset < len check before indexing.

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
rename it as H323_PACKET_NOT_OURS
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
add offset < len checks to avoid buffer overflows.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
what are 1C and 1E. please add some comments and add  necessary #defines
```
1. pradeep June 9, 2025, 1:38 p.m.
  added #define tokens for the same
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/atcp_h323_integration.c (Diff revision 1)
Show all issues
```
define  and add comments to understand the logic better.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)
Show all issues
```
Pass it from Makefile.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)
Show all issues
```
Use Makefile to define macros -DDEBUG_LOG.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)
Show all issues
```
remove whitespace changes from all other places.
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)

Show all issues

if (extpresent)

pradeep June 9, 2025, 1:38 p.m.

this library has folloed this style. I thin there thousands of if statements and other statements where they followed same style.

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/constr_SEQUENCE.c (Diff revision 1)

Show all issues

we dont use uper.. do we need this change ?

pradeep June 9, 2025, 1:38 p.m.

right we only need aper. But somehow for h245 ack this function was being used even though we have used the "aper" API. 

So under the function "SEQUENCE_decode_uper" I had to replace it with the code "SEQUENCE_decode_aper"

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/per_opentype.c (Diff revision 1)
Show all issues
```
these logs are not useful..  clean them up.
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libparser/commands.pm (Diff revision 1)

Show all issues

make the cli h225 nat enable and h245 nat enable

pradeep June 9, 2025, 1:38 p.m.

done.
AN(config)#h323 ?
nat enable/disable natting

AN(config)#h323 nat ?
disable Disable H323 natting
enable Enable H323 natting

we will have only one CLI. which enable both h225 and h245 protocols

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libparser/commands.pm (Diff revision 1)
Show all issues
```
Enable H225 natting.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libparser/commands.pm (Diff revision 1)
Show all issues
```
Configute H245 natting.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libparser/commands.pm (Diff revision 1)
Show all issues
```
Enable H245 natting.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libparser/commands.pm (Diff revision 1)
Show all issues
```
Disable H245 natting
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
H225_ENABLED for better readability. Same for H245.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
it is a config rather than a status.
```
branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
Make it explicit.. H225 natting.
```

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)

Show all issues

can we split nat_h323_payload into two functions 
nat_h225_payload() and nat_h245_payload(),
Otherwise, fixing one might break other one..

branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/src/sys/click/netinet/click_input.c (Diff revision 1)
Show all issues
```
write memory changes missing.. reboot and check. 
Also, do we need clear CLI?
```

Diff:

Revision 2 (+1017 -197)

Show changes

	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/bin/backend/sys_tool.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/ANY.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/BIT_STRING.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/BOOLEAN.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/H2250LogicalChannelParameters.h
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/INTEGER.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile.am.libasncodec
	23 more

Testing Done:

		tested H225 setup. H245 OpenLogicChannel and OpenLogicChannelAck packets. Payloads of these protocol updated with NAT IP replacing the local ip.

~		Cli added:
	~
-		AN(config)#h225 ?
-		disable Disable H225 protocol
-		enable Enable H225 protocol

~		AN(config)#h245 ?
	~
-		disable Disable H245 protocol
-		enable Enable H245 protocol

~		AN(config)#show h225
	~	Cli added:
-		H225 protocol is enabled.

~		AN(config)#show h245
~		H245 feature is enabled.
	~	AN#sh h323
	~	H323 natting is enabled.
	+
	+	AN#
	+	AN(config)#h323 ?
	+	nat enable/disable natting
	+
	+	AN(config)#h323 nat ?
	+	disable Disable H225 natting
	+	enable Enable H323 natting
	+
	+	AN(config)#h323 nat enable
	+
	+	AN(config)#

Diff:

Revision 3 (+1017 -197)

Show changes

	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/bin/backend/sys_tool.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/ANY.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/BIT_STRING.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/BOOLEAN.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/H2250LogicalChannelParameters.h
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/INTEGER.c
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile
	branches/rel_apv_10_7_2_17_bhel_h323_nat/usr/click/lib/libasn1c/Makefile.am.libasncodec
	23 more

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

AE-1179 Support H323 video conference feature

define and add comments to understand the logic better.

Diff:

Testing Done:

Diff:

Status: Closed (submitted)