AA-2844 : Fix platform dependencies and compile time issues

Review Request #867 — Created May 15, 2025 and submitted May 20, 2025, 1:06 p.m.

Information
Owner:	pmurugaiyan
Repository:	AMP
Branch:	amp_4_0
Bugs:	AA-2844
Depends On:
Reviewers
Groups:
People:	apoorva.sn, mmiriam, ngurunathan, prajesh

Description

Fix platform dependencies and compile time issues
1. Fixed a couple of compile time issues
2. Thanks Madhuri for the assistance.

Note: Not all the compilation errors are resolved. Commiting the changes that I did so far.

Testing Done

The changes are tested locally.

Issues

Description	From	Last Updated
keep this memeset for tmp1 and tmp2	mmiriam	May 15, 2025, 7:45 p.m.
keep this	mmiriam	May 15, 2025, 7:45 p.m.
buf is allocated with size MAX_LINE_SIZE + 1 and max_buff = 4096 may cause buffer overflow. So calloc buf with …	mmiriam	May 15, 2025, 7:45 p.m.
size should be 2 only. pos is a. pointer takes 4 or 8bytes.	prajesh	May 19, 2025, 7:28 p.m.

branches/amp_4_0/src/backend/sys_cmd.c (Diff revision 1)
Show all issues
```
keep this memeset for tmp1 and tmp2
```
branches/amp_4_0/src/backend/sys_cmd.c (Diff revision 1)
Show all issues
```
keep this
```

branches/amp_4_0/src/backend/sys_tool.c (Diff revision 1)

Show all issues

buf is allocated with size MAX_LINE_SIZE + 1 and max_buff = 4096 may cause buffer overflow. So calloc buf with 4096.

Same for other places also

Diff:

Revision 2 (+63 -70)

Show changes

	branches/amp_4_0/amp.spec
	branches/amp_4_0/src/backend/backend.c
	branches/amp_4_0/src/backend/sys_cmd.c
	branches/amp_4_0/src/backend/sys_tool.c
	branches/amp_4_0/src/backend/sys_update.c
	branches/amp_4_0/src/cli/Makefile
	branches/amp_4_0/src/cli/shell.c
	branches/amp_4_0/src/library/libpyexauth/Makefile
	3 more

branches/amp_4_0/src/backend/backend.c (Diff revision 2)

Show all issues

size should be 2 only. pos is a. pointer takes 4 or 8bytes.

pmurugaiyan May 19, 2025, 12:48 p.m.

Yes Praveen, it was working with CentOS, but with the Rocky Linux facing the following issue, I updated to address this error.
backend.c: In function 'read_cmd':

backend.c:466:17: error: 'strncpy' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]

  466 |                 strncpy(pos, " \n", 2);

      |                 ^_~_~_~_~_~_~_~

cc1: all warnings being treated as errors

make[3]: *** [Makefile:51: backend.o] Error 1

make[3]: Leaving directory '/home/admin/AMP/amp_4_0/build/array/BUILD/amp-4.0.0/src/backend'

prajesh May 19, 2025, 4:49 p.m.

You can try snprintf instead of strlpcy. snprintf(pos,  2, "\n");

pmurugaiyan May 19, 2025, 7:28 p.m.
```
Yes, worked.
```

Diff:

Revision 3 (+63 -70)

Show changes

	branches/amp_4_0/amp.spec
	branches/amp_4_0/src/backend/backend.c
	branches/amp_4_0/src/backend/sys_cmd.c
	branches/amp_4_0/src/backend/sys_tool.c
	branches/amp_4_0/src/backend/sys_update.c
	branches/amp_4_0/src/cli/Makefile
	branches/amp_4_0/src/cli/shell.c
	branches/amp_4_0/src/library/libpyexauth/Makefile
	3 more

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.5

AA-2844 : Fix platform dependencies and compile time issues

Diff:

Diff:

Status: Closed (submitted)