AA-2955 : Create web pages & API integration for Devices & Device Groups

Review Request #940 — Created June 25, 2025 and submitted

Information
pmurugaiyan
AMP
amp_4_0
AA-2955
Reviewers
apoorva.sn, mmiriam, ngurunathan, shuinvy 
AMP - Devices page completed.
The changes has been tested locally.

Description From Last Updated

Can we include comments what logic each file handles and also add comments to each function on what is taken …

 apoorva.snapoorva.sn
shuinvy
shuinvy 
  1. Ship It!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




apoorva.sn




   

   







  

 



 

  


   

   

    
 
apoorva.sn


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Can we include comments what logic each file handles and also add comments to each function on what is taken care as part of that function.
    
Also add comments to any logic where required
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I can add the comments whereever required, but dont think its required for each functions.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      It will be good to add as anyone new looking at the code can easily understand and need not go through the entire logic to understand what is happening. This is also a good practise to follow when we do introduce new code.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Yes, good practices are good, and we also follow certains practises from naming conventions to folder strctures. But we can't give everything from our code itself, let the newbies do some homework too. Will have help text at complex functions but basics they/anyone should work on it.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Totally agree — good practices are there for a reason. Adding brief comments helps others, understand the code without digging through all the logic.
      

      Doesn’t have to be overdone, just enough context at file and function level to keep things clear. Would be great to follow this consistently going forward.
      
 
      

      5. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




pmurugaiyan




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...